runtime_common: always use memcpy in STORE_PTR#4900
Open
sjamesr wants to merge 1 commit intobytecodealliance:mainfrom
Open
runtime_common: always use memcpy in STORE_PTR#4900sjamesr wants to merge 1 commit intobytecodealliance:mainfrom
sjamesr wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
sjamesr
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
This is one of the many causes of unaligned load warnings in -fsanitize=alignment. memcpy should always be OK: on architectures where unaligned stores are OK, this will turn into a single move. This was discussed back in 2024 at bytecodealliance#2349.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the many causes of unaligned load warnings in -fsanitize=alignment. memcpy should always be OK: on architectures where unaligned stores are OK, this will turn into a single move.
This was discussed back in 2024 in #2349. It seems as though the consensus at the time was to use
memcpy, but I don't know if any changes were made after that.What do you think?